Skip to content

[all] Fix float compilation#6115

Open
bakpaul wants to merge 4 commits into
sofa-framework:masterfrom
bakpaul:26_05_fix_float_compilation
Open

[all] Fix float compilation#6115
bakpaul wants to merge 4 commits into
sofa-framework:masterfrom
bakpaul:26_05_fix_float_compilation

Conversation

@bakpaul
Copy link
Copy Markdown
Contributor

@bakpaul bakpaul commented May 18, 2026

In the process of testing a CUDA PR I compiled SOFA in float. These where the required changes.
I left out all of the SoftRobotic suite (SoftRobots, SoftRobots.Inverse and MOR) because it touched to critical part such as solvers. I guess that if one day we really want to compile it in float we'll have to take the time to clean them properly.

[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/229]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/611]

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented May 18, 2026

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@bakpaul bakpaul added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels May 18, 2026
…nent/collision/detection/intersection/CCDTightInclusionIntersection.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented May 19, 2026

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented May 19, 2026

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 21, 2026
@hugtalbot hugtalbot changed the title [All] Fix float compilation [all] Fix float compilation May 21, 2026
@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented May 21, 2026

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants