[Sofa.GL] DrawToolGL: improve indices text rendering quality#6093
Merged
hugtalbot merged 5 commits intoMay 21, 2026
Conversation
The indices text now maintains a constant screen-space size regardless of zoom level and scene dimensions, removing the need to manually adjust showIndicesScale per scene. - Compute per-vertex scale from the projection matrix and camera depth in GlText::textureDraw_Indices - Handle both perspective and orthographic projections - Add alpha blending for smoother text rendering - Update all callers to pass a dimensionless multiplier (default 1.0) instead of bbox-dependent world-space size
- Add drop shadow (black, 70% opacity, 1.5px offset) behind each label for readability against any background - Disable depth test so indices always render on top of geometry - Enable mipmaps on the ASCII texture atlas for cleaner downsampling
fredroy
added
pr: enhancement
Contributor
|
Thank you so much @fredroy |
alxbilger
approved these changes
Apr 27, 2026
bakpaul
approved these changes
Apr 30, 2026
alxbilger
added
pr: status ready
Contributor
|
There were minor conflicts, @fredroy could you check my corrections please? |
Contributor
Author
should be ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
3 improvements:
disable depth test so no more hidden indicesre-enabled per reviewer requestbefore:
PR:
--
EDIT: with depth test
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if