[HyperElastic] Enable the SelfAdjointEigenSolver in Ogden #5953
Open
th-skam wants to merge 5 commits intosofa-framework:masterfrom
Open
[HyperElastic] Enable the SelfAdjointEigenSolver in Ogden #5953th-skam wants to merge 5 commits intosofa-framework:masterfrom
th-skam wants to merge 5 commits intosofa-framework:masterfrom
Conversation
th-skam
added
the
pr: status to review
Contributor
Author
|
On commit 4cba58b the tests are failing after enabling the |
…elfAdjointEigenSolver
Contributor
Author
|
and from f8d31b0 onwards they pass (Material_test.cpp related). |
bakpaul
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bad use of the
SelfAdjointEigenSolverin previous changes. It should not be constructed by passing a bool to the constructor. I assumed this was enabling eigenvector computations, as is the case with the general-purposeEigenSolver.It must have been the case in the old eigen API.
Big thnx to @fredroy for this.
[ci-build][with-all-tests]
Close #5733