[Topology] Add support for adding prism and pyramid elements in MeshTopology#5946
Open
alxbilger wants to merge 4 commits intosofa-framework:masterfrom
Open
[Topology] Add support for adding prism and pyramid elements in MeshTopology#5946alxbilger wants to merge 4 commits intosofa-framework:masterfrom
alxbilger wants to merge 4 commits intosofa-framework:masterfrom
Conversation
Centralize point counting into a reusable `countPoints` method, simplifying element addition functions and improving maintainability.
Introduce `doSetUp` for common initialization, simplifying and improving test code readability.
Add tests for adding point, edge, triangle, quad, tetrahedron, hexahedron, prism, and pyramid elements to verify correct functionality and point counting.
1a32bc3 to
e5fdc6a
Compare
Contributor
|
[ci-buld][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request extends the functionality of the MeshTopology and related classes by adding support for two new element types: Prism and Pyramid. It also improves the implementation of point counting and modifies the test suite to verify the functionality of these additions.
Main changes:
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if