Skip to content

[Config] Enable W4 option for MSVC#5913

Merged
fredroy merged 1 commit intosofa-framework:masterfrom
alxbilger:w4
Feb 19, 2026
Merged

[Config] Enable W4 option for MSVC#5913
fredroy merged 1 commit intosofa-framework:masterfrom
alxbilger:w4

Conversation

@alxbilger
Copy link
Contributor

GCC/clang has already -Wall. This PR introduces the MSVC equivalent. And yes, a lot of warnings will be generated.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 2, 2026
@alxbilger
Copy link
Contributor Author

Generated a 55 MB log file. Searching for warnings in the log file:

Found 1,019 matches within 0% to 3% of file. Search stopped because too many results were found.

Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and msvc was already throwing more warnings than gcc/clang with -Wall 🫠

@bakpaul
Copy link
Contributor

bakpaul commented Feb 4, 2026

55 MB of text is wild.

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 19, 2026
@fredroy fredroy merged commit fa7255c into sofa-framework:master Feb 19, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments