Merged
Conversation
Wrap the five deployment phases (bundle, upload, build, deploy_service, endpoint_provision) with CLIMetrics.span() context managers so each phase duration and errors are captured in CLI telemetry payloads. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <noreply@snowflake.com>
When a build job or deployed service enters FAILED state, fetch the last 50 lines of container logs via SYSTEM$GET_SERVICE_LOGS and print them before re-raising the error. This gives immediate visibility into why a build or deploy failed without requiring a manual log query. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <noreply@snowflake.com>
The cherry-picked telemetry commit only covered the non-artifact-repo code paths. Wrap the artifact-repo build (build_app_artifact_repo + polling) and deploy (run_app_artifact_repo) in matching snowflake_app.build and snowflake_app.deploy_service spans. Made-with: Cursor
The cherry-pick conflict resolution renamed get_service_logs to get_container_logs (SYSTEM$GET_SERVICE_LOGS) to avoid colliding with the existing get_service_logs (SYSTEM$GET_APPLICATION_SERVICE_LOGS). Update the manager unit tests and _fetch_and_print_failure_logs mock tests to use the renamed method. Made-with: Cursor
…ate PR) Made-with: Cursor
Made-with: Cursor
Test that both the image-repo and artifact-repo deploy paths record exactly the expected spans in order (bundle, upload, build, deploy_service, endpoint_provision). Also verify that a build failure records the error class in the span. Uses a shared _make_deploy_mocks helper to reduce duplication with existing deploy tests. Made-with: Cursor
sfc-gh-gbloom
force-pushed
the
gbloom/snowflake-apps-telemetry
branch
from
34fa0bf to
fc2fe3e
Compare
9 tasks
sfc-gh-jfloyd
approved these changes
Apr 14, 2026
sfc-gh-npasala
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Wrap key operations in
CLIMetrics.span()context managers so phase duration and errors are captured in CLI telemetry payloads.setupcommand:snowflake_app.setup.resolve_defaults— fetching account parameters, role, and config table defaultsdeploycommand (both artifact-repo and image-repo paths):snowflake_app.bundle— artifact bundlingsnowflake_app.upload— stage uploadsnowflake_app.build— build job submission and pollingsnowflake_app.deploy_service— service creation/upgradesnowflake_app.endpoint_provision— endpoint URL polling