Mae/business name#90
Open
mae-smarty wants to merge 4 commits into
Open
Conversation
mae-smarty
requested review from
andrea-wait-smarty,
andyjohnsonsmarty and
timothy-smarty
andrea-wait-smarty
requested changes
Jun 10, 2026
| and _is_blank(getattr(lookup, 'business_name', None)) | ||
| ): | ||
| raise SmartyException("Lookup requires one of 'smartykey', 'street', or 'freeform' to be set") | ||
| raise SmartyException("Lookup requires one of 'smartykey', 'street', 'freeform', or 'business_name' to be set") |
There was a problem hiding this comment.
If you make a change according to my Lookup comment, I would change this too to either be smarty_key or businessName
Contributor
Author
There was a problem hiding this comment.
snake case is more consistent with the rest of the file, but I'm concerned about the impact changing smartykey and other inconsistently named variables would have on any customers who set them directly. I think i'll make a clickup task for this and a few other formatting changes that would impact customers so they can be in a separate pr.
andyjohnsonsmarty
requested changes
Jun 11, 2026
mae-smarty
force-pushed
the
mae/business-name
branch
from
e543098 to
3582b76
Compare
andrea-wait-smarty
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the business_name input parameter and associated testing and examples.