Skip to content

XGBoost: Do not panic if a tree split is degenerate#364

Merged
Mec-iS merged 1 commit intosmartcorelib:developmentfrom
Dig-Doug:xg-degenerate
Apr 2, 2026
Merged

XGBoost: Do not panic if a tree split is degenerate#364
Mec-iS merged 1 commit intosmartcorelib:developmentfrom
Dig-Doug:xg-degenerate

Conversation

@Dig-Doug
Copy link
Copy Markdown
Contributor

@Dig-Doug Dig-Doug commented Apr 2, 2026

Fixes #363.

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

XGRegressor can panic.

New expected behaviour

Does not panic.

@Dig-Doug Dig-Doug requested a review from Mec-iS as a code owner April 2, 2026 01:34
@Mec-iS
Copy link
Copy Markdown
Collaborator

Mec-iS commented Apr 2, 2026

thank you. taking a look

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.60%. Comparing base (70d8a0f) to head (8b24cc7).
⚠️ Report is 13 commits behind head on development.

Files with missing lines Patch % Lines
src/xgboost/xgb_regressor.rs 21.42% 22 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #364      +/-   ##
===============================================
- Coverage        45.59%   44.60%   -0.99%     
===============================================
  Files               93       95       +2     
  Lines             8034     8021      -13     
===============================================
- Hits              3663     3578      -85     
- Misses            4371     4443      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mec-iS
Copy link
Copy Markdown
Collaborator

Mec-iS commented Apr 2, 2026

it would be nice if it is possible to have a test to cover the case.

@Mec-iS Mec-iS merged commit 0569813 into smartcorelib:development Apr 2, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XGBoost panic

2 participants