XGBoost: Do not panic if a tree split is degenerate#364
Merged
Mec-iS merged 1 commit intosmartcorelib:developmentfrom Apr 2, 2026
Merged
XGBoost: Do not panic if a tree split is degenerate#364Mec-iS merged 1 commit intosmartcorelib:developmentfrom
Mec-iS merged 1 commit intosmartcorelib:developmentfrom
Conversation
Collaborator
|
thank you. taking a look |
Mec-iS
approved these changes
Apr 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #364 +/- ##
===============================================
- Coverage 45.59% 44.60% -0.99%
===============================================
Files 93 95 +2
Lines 8034 8021 -13
===============================================
- Hits 3663 3578 -85
- Misses 4371 4443 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
it would be nice if it is possible to have a test to cover the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363.
Checklist
Current behaviour
XGRegressor can panic.
New expected behaviour
Does not panic.