Row clickable fix#3770
Open
gfletcher-cll wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
👋 gfletcher-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the user experience and accessibility of the ChainTable and TokenChainsTable components, as well as refining their layout and interaction styles. The main changes include making table rows clickable and keyboard-accessible, refactoring the logic for opening lane details, and enhancing the table's responsive design and visual consistency.
Table Interaction and Accessibility Improvements:
ChainTable.tsxare now clickable and accessible via keyboard (Enter key), allowing users to open lane details by clicking anywhere on the row instead of just the network name button. This also improves accessibility for keyboard users.openLanefunction, simplifying the code and centralizing drawer-opening behavior.Layout and Visual Consistency Updates:
token-logo-with-badgeclass replaces previous logo container styles, standardizing how network and token logos are displayed in both tables. [1] [2]These changes collectively enhance the usability, accessibility, and maintainability of the table components.