Fix Rust SDK WebSocket HA mode origin discovery#69
Merged
Conversation
…set X-Cll-Origin header
akuzni2
reviewed
Jun 2, 2026
| #[test] | ||
| fn test_parse_origins_from_header_with_braces() { | ||
| let result = parse_origins_from_header( | ||
| "{wss://ws1.dataengine.chain.link,wss://ws2.dataengine.chain.link}", |
Collaborator
There was a problem hiding this comment.
for clarity of the actual protocol can we use the hint format {001,002} ?
akuzni2
reviewed
Jun 2, 2026
| let ws_url = format!("ws://{}", mock_server.address()); | ||
|
|
||
| let ws_url = origins.join(","); | ||
| // Configure mock server to return N origins in HEAD response (all pointing to same mock). |
Collaborator
There was a problem hiding this comment.
can we make sure that the Mock websocket server can capture + assert on the X-Cll-Origin header? So 2 separate asserts:
- When HA mode is enabled on WS client:
X-Cll-Originheader is present in request - When HA mode is enabled on WS client: WS Server sees separate origin requests i.e. 001, 002
akuzni2
previously approved these changes
Jun 2, 2026
akuzni2
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.