Skip to content

Add supported-chains cmd & Improve Error Messages#330

Open
ejacquier wants to merge 9 commits intomainfrom
error-improvement
Open

Add supported-chains cmd & Improve Error Messages#330
ejacquier wants to merge 9 commits intomainfrom
error-improvement

Conversation

@ejacquier
Copy link
Copy Markdown
Contributor

@ejacquier ejacquier commented Mar 30, 2026

Supported Chains

  • Added cre workflow supported-chains command (sorted alphabetically)

📊 Error Handling Improvements

# Top Error (CSV) Count Improvement
1 no project settings file found 321 Now: clearer message ("no CRE project found") + suggests cre init, --project-root, or cd into project
2 Script not found "cre-compile" 303 Now: explains it comes from @chainlink/cre-sdk + suggests bun install / cre update
3 no RPC URLs found 178 Now: shows which target failed + suggests checking rpcs section and --supported-chains
4 failed to parse private key 159 Now: shows actual vs expected length (64 hex chars) + lists common mistakes
5 workflow.yaml: no such file or directory 155 Now: clearer message ("workflow settings file not found") + suggests cre workflow init or checking path

@ejacquier ejacquier requested a review from a team as a code owner March 30, 2026 15:50
@github-actions
Copy link
Copy Markdown

👋 ejacquier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@ejacquier ejacquier changed the title Improve Error messages Add supported-chains cmd & Improve Error Messages Mar 30, 2026
Comment thread cmd/workflow/simulate/simulate.go Outdated
target = "(none)"
}
return Inputs{}, fmt.Errorf(
"no RPC URLs found for target %q\n\n"+
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a generalised rpc check in the root of the cmd package?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. cmd/root.go has isLoadDeploymentRPC() which decides whether to load RPC settings (for deploy/pause/activate/delete). That's a
config-loading gate, not a validation error.

Comment thread cmd/workflow/workflow.go Outdated
timothyF95
timothyF95 previously approved these changes Apr 15, 2026
@tarcisiozf tarcisiozf enabled auto-merge April 23, 2026 14:44
@ejacquier ejacquier dismissed timothyF95’s stale review April 23, 2026 16:01

The merge-base changed after approval.

Comment thread cmd/root.go
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

⚠️ Abigen Fork Check - Update Available

The forked abigen package is outdated and may be missing important updates.

Version Value
Current Fork v1.17.0
Latest Upstream null

Action Required

  1. Review abigen changes in upstream (only the accounts/abi/bind directory matters)
  2. Compare with our fork in cmd/generate-bindings/bindings/abigen/
  3. If relevant changes exist, sync them and update FORK_METADATA.md
  4. If no abigen changes, just update the version in FORK_METADATA.md to null

Files to Review

  • cmd/generate-bindings/bindings/abigen/bind.go
  • cmd/generate-bindings/bindings/abigen/bindv2.go
  • cmd/generate-bindings/bindings/abigen/template.go

⚠️ Note to PR author: This is not something you need to fix. The Platform Expansion team is responsible for maintaining the abigen fork.

cc @smartcontractkit/bix-framework

Comment thread cmd/workflow/supported_chains/supported_chains.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants