feat: add support for multiple api key to deploy workflow#55
Draft
ecPablo wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for selecting among multiple named CRE API keys when deploying a workflow, by introducing an
APIKeyNamefield to the deployment input and updating the workflow deploy operation accordingly. It also includes new tests to verify the correct propagation and error handling for this feature. Additionally, themcmsdependency is updated to a new version.Feature: Support for selecting named CRE API keys
APIKeyNamefield to theCREWorkflowDeployInputstruct, allowing users to specify which CRE API key to use when multiple are configured.CREWorkflowDeployOpoperation to use the specifiedAPIKeyNameby callingWithNamedAPIKeyon the CLI runner before performing any CLI operations. The operation version was bumped to 1.1.0 to reflect this change. [1] [2] [3]Testing: Enhanced test coverage for API key selection
APIKeyNameis correctly propagated through the deployment changeset and to the CLI runner, and that errors are handled when an unknown API key is specified. [1] [2]Dependencies
mcmsdependency from v0.41.1 to v0.42.0 ingo.mod.Go module housekeeping
chainlink-ton/deploymentdependency to the indirect section ingo.modfor consistency.