chore: replace mcms helpers usages [OPT-1911]#22019
Draft
Conversation
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all usages of
proposalutils/mcms_helpers.gowith CLDF functions.AI Summary
This pull request refactors test and implementation code to consistently use shared helper utilities for MCMS (Multi-Chain Management System) proposal creation, execution, and configuration. The main changes involve replacing direct imports and usage of the local
proposalutilspackage with the sharedcldftesthelpersandcldfproposalutilsmodules from thechainlink-deployments-framework. This improves code reuse, maintainability, and consistency across the codebase.Test code refactoring:
Replaced
proposalutils.SingleGroupMCMSV2and related helpers withcldftesthelpers.SingleGroupMCMSin multiple test files, includingcs_deploy_aptos_chain_test.go,test_helpers.go,test_helpers_aptos.go,test_helpers_solana_v0_1_0.go, andtest_helpers_solana_v0_1_1.go. This standardizes MCMS test configuration and reduces duplication. [1] [2] [3] [4] [5] [6] [7]Updated test execution helpers to use
cldftesthelpersfor signing and executing MCMS proposals, replacing previousproposalutilscalls in cross-family and Solana-related tests.Implementation code refactoring:
proposalutils.McmsInspectorForChain,proposalutils.BatchOperationForChain, andproposalutils.TransactionForChainto use the sharedcldfproposalutilspackage in several implementation files, includingcs_rmn.go,cs_add_registry_module.go,cs_ccip_home.go, andcs_chain_contracts.go. This centralizes MCMS proposal logic and reduces the risk of divergence. [1] [2] [3] [4] [5] [6] [7] [8]Import cleanup and consistency:
proposalutilsand instead importcldftesthelpersandcldfproposalutilswhere needed, improving clarity and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]These changes help ensure that all MCMS-related proposal logic and test helpers are sourced from a single, shared location, reducing duplication and the risk of inconsistencies.