Draft
Conversation
40c4976 to
4132410
Compare
Contributor
|
I see you updated files related to
|
…al-workflows_backwardscomp [CRE-1748] make sharding configurable and backwards compatible
…lthy shards; test improvement
|
28c8a2d to
2977c58
Compare
bolekk
reviewed
Feb 19, 2026
Contributor
bolekk
left a comment
There was a problem hiding this comment.
It looks like all new code is properly feature-flagged in application/delegate/syncer. I don't mind merging it once it's rebased on develop.
| engineRegistry, | ||
| syncerV2.WithAdditionalSources(addSourceConfigs), | ||
| syncerV2.WithShardEnabled(true), | ||
| syncerV2.WithShardOrchestratorClient(opts.ShardOrchestratorClient), |
Contributor
There was a problem hiding this comment.
Can you collect those extra params if sharding is enabled and then pass to one shared call to NewWorkflowRegistry()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




PR contains:
CRE-1714