Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TON deployment test adapter and related bindings to support QA-oriented test flows (message ID plumbing, receiver behavior toggles, allowlist/RMN helpers), and adds initial QA documentation.
Changes:
- Extend TON test adapter with new QA helper methods (message ID return, execution validation, allowlist + RMN curse toggles, etc.).
- Update receiver bindings (exported behavior constants + new TL-B message structs) and adjust deployment code to use new names.
- Add QA test documentation and update the deployment module dependency on
chainlink-ccip/deployment.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/ccip/bindings/receiver/receiver.go | Renames behavior constants and adds TL-B message structs for receiver admin ops. |
| docs/tests/qa.md | Adds QA testing documentation (automated vs interactive flows). |
| deployment/testadapter/test_adapter.go | Adds/updates TON QA adapter methods and execution filtering; returns message ID from SendMessage. |
| deployment/go.mod | Bumps chainlink-ccip/deployment dependency version. |
| deployment/go.sum | Updates sums for the bumped deployment dependency. |
| deployment/ccip/sequence/deploy_ccip.go | Updates receiver behavior constant usage to the renamed identifier. |
| deployment/ccip/1_6_0/sequences/deploy_chain_contracts.go | Moves interface compliance assertion to a more visible location. |
| deployment/ccip/1_6_0/sequences/connect_chains.go | Same as above for lane adapter; minor import grouping tweak. |
| .github/workflows/test-smoke.yml | Points smoke workflow at a non-main branch in the target repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WORKFLOW_FILE: .github/workflows/test_smoke.yml | ||
| TARGET_REPO: smartcontractkit/chainlink-ccip | ||
| TARGET_BRANCH: main | ||
| TARGET_BRANCH: ton-qa-tests # TODO change back to main |
There was a problem hiding this comment.
This workflow is pinned to TARGET_BRANCH: ton-qa-tests with a TODO to change back. Merging this as-is will make the smoke workflow depend on a non-default branch in smartcontractkit/chainlink-ccip, which is brittle and may break CI once that branch is deleted or diverges. Please restore main (or make the branch configurable via workflow input).
Suggested change
| TARGET_BRANCH: ton-qa-tests # TODO change back to main | |
| TARGET_BRANCH: main |
Collaborator
Author
There was a problem hiding this comment.
As intended
… rollback all others
jadepark-dev
reviewed
Apr 1, 2026
jadepark-dev
reviewed
Apr 1, 2026
| shellHook = '' | ||
| # use upstream golangci-lint config from core Chainlink repository, overriding the local prefixes | ||
| alias golint="CGO_ENABLED=0 golangci-lint run --config <(curl -sSL https://raw.githubusercontent.com/smartcontractkit/chainlink/develop/.golangci.yml | yq e '.formatters.settings.goimports.local-prefixes = [\"github.com/smartcontractkit/chainlink-ton\"]' -) --path-mode \"abs\"" | ||
| alias golint="CGO_ENABLED=1 golangci-lint run --config <(curl -sSL https://raw.githubusercontent.com/smartcontractkit/chainlink/develop/.golangci.yml | yq e '.formatters.settings.goimports.local-prefixes = [\"github.com/smartcontractkit/chainlink-ton\"]' -) --path-mode \"abs\"" |
Collaborator
There was a problem hiding this comment.
Can you add comment about CGO flag
Collaborator
Author
There was a problem hiding this comment.
We can remove it. CGO defaults to 1
huangzhen1997
force-pushed
the
devenv-qa-tests
branch
from
ba57589 to
aad694b
Compare
Collaborator
2 tasks
2 tasks
This reverts commit c5269c2.
…nk-ton into devenv-qa-tests
huangzhen1997
approved these changes
Apr 7, 2026
krebernisak
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires chainlink-ccip bump in core smartcontractkit/chainlink#21851
Supports: smartcontractkit/chainlink-ccip#1756