all capabilities emit beholder logs automatically#1844
Closed
patrickhuie19 wants to merge 1 commit intomainfrom
Closed
all capabilities emit beholder logs automatically#1844patrickhuie19 wants to merge 1 commit intomainfrom
patrickhuie19 wants to merge 1 commit intomainfrom
Conversation
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
patrickhuie19
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
Contributor
Author
|
cc @pkcll |
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at some gaps in logs from trigger capabilities in prod, I realized we could benefit in the capabilities by pushing everything through the beholder logger. The alternative is leaving it up to individual capabilities as to which of their logs go through beholder or not, but as we expect logs to eventually end up in our internal log viewer, this shouldn't be a security issue anyways.