Conversation
|
👋 wentzeld, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
There was a problem hiding this comment.
Pull request overview
This PR is part of the "Wave 1.5 Error Improvements" initiative, aimed at improving observability and error reporting in the consensus reporting plugin. The change elevates a log message from Debug level to Warning level and enhances it with more detailed context when insufficient observations prevent consensus from being reached.
Changes:
- Elevated log level from
DebugwtoWarnwfor insufficient observations condition (< 2f+1 nodes) - Enhanced error message with clearer explanation of why consensus was skipped
- Added structured fields:
observationCount,requiredCount,workflowExecutionID, andworkflowID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
|
||
| if len(obs) < (2*r.config.F + 1) { | ||
| lggr.Debugw("insufficient observations for workflow execution id") | ||
| lggr.Warnw("Insufficient observations for workflow execution: consensus skipped because fewer than 2f+1 nodes reported observations", |
There was a problem hiding this comment.
This does't make it more visible in any way.
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
Changes: Reporting plugin: Debugw elevated to Warnw for insufficient observations
Dependencies: None
See CRE Error Improvements for more details