Aggregator metrics followups by AndresJulia · Pull Request #656 · smartcontractkit/chainlink-ccv

AndresJulia · 2026-02-09T16:17:12Z

addressing items listed in https://smartcontract-it.atlassian.net/browse/CCIP-9316

aggregator/pkg/monitoring/metrics.go

github-actions · 2026-02-11T12:57:04Z

Code coverage report:

Package	`main`	`CCIP-9316_agg_metric_gaps`	diff
github.com/smartcontractkit/chainlink-ccv/aggregator	46.95%	46.95%	+0.00%
github.com/smartcontractkit/chainlink-ccv/cmd	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/committee	100.00%	100.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/common	0.00%	0.00%	+0.00%

WARNING: go tool cover failed for coverage_target.out
cover: no required module provides package github.com/smartcontractkit/chainlink-ccv/common/jd/client; to add it:
go get github.com/smartcontractkit/chainlink-ccv/common/jd/client
WARNING: go tool cover failed for coverage.out
cover: no required module provides package github.com/smartcontractkit/chainlink-ccv/common/jd/client; to add it:
go get github.com/smartcontractkit/chainlink-ccv/common/jd/client

emate · 2026-02-11T13:00:51Z

aggregator/pkg/common/metrics.go

 	RecordAPIRequestDuration(ctx context.Context, duration time.Duration)
 	// IncrementAPIRequestErrors increments the API request errors counter.
-	IncrementAPIRequestErrors(ctx context.Context)
+	IncrementAPIRequestErrors(ctx context.Context, method string)


What's the purpose of adding a method here? This is grpc and AFAIK method name is automatically included in the context

chainlink-ccv/aggregator/pkg/middlewares/scoping_middleware.go

Lines 15 to 16 in 55c4e97

ctx = scope.WithAPIName(ctx, info.FullMethod)

return handler(ctx, req)

its more explicit IMO - opinionated? im fine with any option

Aggregator metrics followups

1d11d5e

AndresJulia requested review from a team and skudasov as code owners February 9, 2026 16:17

AndresJulia requested a review from bukata-sa February 9, 2026 21:21

bukata-sa reviewed Feb 10, 2026

View reviewed changes