refactor(config): rename Teams→ServerEdition (internal/teams→serveredition, teams→server_edition key + alias) (MCP-1086)#603
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
c0a758e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f9184e0.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://rename-teams-to-servereditio.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 27397915729 --repo smart-mcp-proxy/mcpproxy-go
|
Codex review follow-up for PR #603 / MCP-1086: - generate-release-notes.sh: server-edition code path internal/teams/ → internal/serveredition/ - specs/029-mcpproxy-teams/tasks.md: build-tag docs //go:build teams / -tags teams → server, matching the accepted scope (build tag remains "server", current code uses //go:build server). Package paths were already renamed by PR #603; only the build-tag references were stale. Edition-name/wording strings left untouched (owned by MCP-1087). Related #603
…nd related docs All //go:build teams, -tags teams, internal/teams/ references updated to //go:build server, -tags server, internal/serveredition/ to match the actual build tags used throughout the codebase. Related #603
Code Review —
|
…ition; teams→server_edition key (alias)
Renames the server-edition surface for clarity and to disambiguate from any
"teams" collaboration concept (MCP-1086).
Go:
- config.TeamsConfig→ServerEditionConfig, TeamsOAuthConfig→ServerEditionOAuthConfig,
DefaultTeamsConfig→DefaultServerEditionConfig; Config.Teams→Config.ServerEdition.
- Config key/tag teams→server_edition. Legacy "teams" key still loads onto
ServerEdition via normalize-on-load in loadConfigFile (new key wins). Compiles
in both editions (ServerEditionConfig is a struct{} stub in personal builds).
- Move internal/teams/→internal/serveredition/ (package teams→serveredition,
incl. broker/ from #588); update all imports and selectors.
- Rename exported symbols: TeamsAuthMiddleware→ServerEditionAuthMiddleware,
TeamsStatusInfo→ServerEditionStatusInfo, TeamsInfo→ServerEditionInfo,
wireTeamsOAuth→wireServerEditionOAuth.
- `mcpproxy status -o json` server-edition block key teams→server_edition (aligns
output with the rename).
Edition strings ("personal"/"server"), the `server` build tag, and the
edition_teams.go build-tag filename are unchanged per scope.
Tests:
- New file-load back-compat tests: new server_edition key, legacy teams key,
and both-keys-new-wins (server-tagged).
Docs:
- CLAUDE.md path/config-key references (kept under the 40k char gate); active
feature docs; specs config-key + code-path references. Spec directory slugs
(029-mcpproxy-teams, 024-teams-multiuser-oauth) and historical narrative are
preserved intact.
swagger: teams config is swaggerignore — no REST surface change (verified).
Related MCP-1086
Codex review follow-up for PR #603 / MCP-1086: - generate-release-notes.sh: server-edition code path internal/teams/ → internal/serveredition/ - specs/029-mcpproxy-teams/tasks.md: build-tag docs //go:build teams / -tags teams → server, matching the accepted scope (build tag remains "server", current code uses //go:build server). Package paths were already renamed by PR #603; only the build-tag references were stale. Edition-name/wording strings left untouched (owned by MCP-1087). Related #603
…nd related docs All //go:build teams, -tags teams, internal/teams/ references updated to //go:build server, -tags server, internal/serveredition/ to match the actual build tags used throughout the codebase. Related #603
d7c5557 to
e06cd9e
Compare
…n key (MCP-1086) Address CodexReviewer REQUEST_CHANGES on PR #603. The backend renamed the canonical config key teams -> server_edition; the settings UI was still bound to the legacy teams object, so after the rename the Server Edition tab would disappear and edits would reintroduce the legacy key. - Settings.vue: gate the Server Edition tab on server_edition (fallback to the legacy teams key), and alias a legacy teams-keyed config onto server_edition at load so old configs still hydrate the form. - settings/fields.ts: write/read the canonical server_edition.* dot-paths; the shared SettingsSection read (getPath) and PATCH partial (buildPartial) follow the field keys, so both now target server_edition. - idp-token-storage.md + idp_subject_token.go: rename operator-facing refs to server_edition, noting teams is still accepted as a back-compat alias. Verified: vitest (server-edition wording spec), frontend build (vue-tsc), go build -tags server ./cmd/mcpproxy, go build ./cmd/mcpproxy. Related #603
Summary
Renames the server-edition surface for clarity (MCP-1086). Blocked-by #588/MCP-1035 — now merged, so this lands the rename on top.
TeamsConfig→ServerEditionConfig,TeamsOAuthConfig→ServerEditionOAuthConfig,DefaultTeamsConfig→DefaultServerEditionConfig;Config.Teams→Config.ServerEdition.teams→server_edition, with back-compat: an existing config that still usesteamsis normalized ontoServerEditionon load (new key wins). Implemented inloadConfigFilemirroring the feat(registry): simplify trust/quarantine + add edit endpoint (MCP-1072) #594 provenance normalize-on-read. Compiles in both editions (ServerEditionConfigis astruct{}stub in personal builds).internal/teams/→internal/serveredition/(41 files +broker/from feat(config): per-upstream auth_broker block + teams credential keys (spec 074, MCP-1035) #588),package teams→serveredition; all imports/selectors updated.TeamsAuthMiddleware→ServerEditionAuthMiddleware,TeamsStatusInfo→ServerEditionStatusInfo,TeamsInfo→ServerEditionInfo,wireTeamsOAuth→wireServerEditionOAuth.mcpproxy status -o jsonserver-edition block keyteams→server_edition(aligns output with the rename).Unchanged per scope:
personal/serveredition strings, theserverbuild tag, and theedition_teams.gobuild-tag filename.Tests
server_editionkey, legacyteamskey, both-keys-new-wins.go build ./cmd/mcpproxy(personal) ✅ andgo build -tags server ./cmd/mcpproxy✅go test -tags server ./internal/serveredition/... -race✅ (all packages)go vet ./...andgo vet -tags server ./...✅./scripts/run-linter.sh→ 0 issues ✅Docs
CLAUDE.mdpath + config-key references updated, kept under the 40k char gate (39,969/40,000; tightened a few descriptions to offset growth).029-mcpproxy-teams,024-teams-multiuser-oauth), historical spec narrative prose, and the archiveddocs/plans/2026-03-08-repo-restructure-design.md(it records the original-tags teamsdesign).swagger
teamsconfig isswaggerignore— no REST surface change (verified: noteams/ServerEditionrefs inoas/swagger.yaml).Unblocks the frontend rename task (B).
Related MCP-1086