Skip to content

fix: logging interpolation bug in plugin.py when an error happens while pickling the results #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jonas1312 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: logging interpolation bug in plugin.py when an error happens while pickling the results #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de9a75
fix: logging interpolation bug in plugin.py
Jonas1312 Mar 26, 2026
6e29d8b
Update changelog for version 1.11.1: fixed xdist pickling error logging
Jonas1312 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Changelog

### 1.11.0 - dropped support for python < 3.9 and fixed - pytest 8.4.0 (in progress)
### 1.11.1 - fixed xdist pickling error logging (in progress)

- Fixed a `TypeError` raised when an error occurs while pickling the xdist worker results.
PR [#85](https://github.com/smarie/python-pytest-harvest/pull/85) by [@Jonas1312](https://github.com/Jonas1312).

### 1.11.0 - dropped support for python < 3.9 and fixed - pytest 8.4.0

- Dropped support for python <3.9 and added a proper github pages workflow (explicit). Removed `six` from dependencies.
Fixed [#79](https://github.com/smarie/python-pytest-harvest/issues/79)
Expand Down
2 changes: 1 addition & 1 deletion src/pytest_harvest/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def pytest_harvest_xdist_worker_dump(self, worker_id, session_items, fixture_sto
try:
pickle.dump((session_items, fixture_store), f)
except Exception as e:
warning("Error while pickling worker %s's harvested results: [%s] %s", (worker_id, e.__class__, e))
warning("Error while pickling worker %s's harvested results: [%s] %s", worker_id, e.__class__, e)
return True

@pytest.hookimpl(trylast=True)
Expand Down