#400: Add support for GraphQL unions (1.6.x) #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 896de9f) format and impsort
phillip-kruger
approved these changes
Jul 20, 2022
Member
phillip-kruger
left a comment
phillip-kruger
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for this @craig-day - this is awesome. I think we should be able to move this to the spec soon. Next step is to get this into a runtime like Quarkus. For Quarkus we might have to do some work to get the classes registered. Are you keen to look at this ? If so we can do a SmallRye release once this is merge and you can look at the Quarkus implementation ?
Member
|
We would also need some documentation in the Quarkus Guide... |
Member
|
Ok v1.6.1 is released (https://github.com/smallrye/smallrye-graphql/releases/tag/1.6.1) @craig-day are you keen to get this into Quarkus ? I can assist if needed |
Contributor
Author
|
@phillip-kruger I'll give it a shot today and see how it goes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports #1469 to be against 1.6.x (javax)