feat: add MACFilter for network interface classification#6
Merged
christiangda merged 2 commits intomainfrom Feb 14, 2026
Merged
feat: add MACFilter for network interface classification#6christiangda merged 2 commits intomainfrom
christiangda merged 2 commits intomainfrom
Conversation
Add MACFilter type (Physical, All, Virtual) to control which network interfaces contribute to the machine ID. Physical-only (default) provides the most stable IDs on bare metal; All includes virtual interfaces for maximum uniqueness; Virtual-only supports container fingerprinting. Backward compatible: WithMAC() with no args behaves identically to before. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing periods to all doc comment sentences - Use "reports whether" for bool-returning functions (Validate, isValidUUID, isValidSerial, isNonEmpty, isVirtualInterface) - Add [Symbol] doc links for cross-references (FormatMode, DiagnosticInfo, Provider.ID) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MACFiltertype with three modes:MACFilterPhysical(default),MACFilterAll, andMACFilterVirtualto control which network interfaces contribute to machine ID generationWithMAC()to accept an optionalMACFilterparameter (backward compatible — no args = physical only)-mac-filterCLI flag (physical,all,virtual)Test plan
-raceenabledTestCollectMACAddressesAllFilter,TestCollectMACAddressesVirtualFilter,TestMACFilterString,TestWithMACBackwardCompatibility,TestWithMACFilter,TestWithMACFilterAffectsIDgo build ./...andgo vet ./...cleango run ./cmd/machineid -mac -mac-filter all -diagnostics🤖 Generated with Claude Code