Merged
Conversation
Add 37 new tests covering logger code paths, error type assertions, edge cases, and CLI helper functions. Library coverage: 89.6% → 98.0% (+8.4%) CLI coverage: 0.0% → 20.3% (new) Total coverage: 59.2% → 71.6% (+12.4%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests using mock executor with darwin-specific commands (sysctl, system_profiler, ioreg) fail on Linux CI because Linux's collectIdentifiers reads from filesystem directly. Move these tests to darwin build-tagged files. Also move Example_integrity and ExampleProvider_Diagnostics which make darwin-specific assumptions about collected component counts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go test -v -race -count=1 ./...— all tests passgo vet ./...— no warningsgo test -coverprofileandgo tool cover -func🤖 Generated with Claude Code