-
Notifications
You must be signed in to change notification settings - Fork 182
build: update @actions dependencies to versions with esm support #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 95.90% 95.92% +0.01%
==========================================
Files 14 14
Lines 2686 2697 +11
==========================================
+ Hits 2576 2587 +11
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪬 A note for wonderful reviewers!
| @@ -1,4 +1,4 @@ | |||
| import core from "@actions/core"; | |||
| import * as core from "@actions/core"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ note: This is now recognized as the single import of @actions/core since other references can be shown in "jsdoc" for typechecking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the note!
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Woohoo, thanks @zimeg! Lint and test pass and the code changes look straight-forward. Let's merge this! ![]()
| @@ -1,4 +1,4 @@ | |||
| import core from "@actions/core"; | |||
| import * as core from "@actions/core"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the note!
Summary
This PR replaces #542 and #544 with changes to use the latest ESM support exported from these packages 🎁
Requirements