Skip to content

test: increase test coverage for activity package event routing#420

Open
mwbrooks wants to merge 2 commits intomainfrom
mwbrooks-test-coverage-7
Open

test: increase test coverage for activity package event routing#420
mwbrooks wants to merge 2 commits intomainfrom
mwbrooks-test-coverage-7

Conversation

@mwbrooks
Copy link
Member

Changelog

  • N/A

Summary

This pull request increasing test coverage for the internal/pkg/platform/activity package.

  • Add tests for prettifyActivity event type routing to verify event types
  • Brings prettifyActivity coverage from 33.3% to 97.0%

Requirements

…outing

Add tests for prettifyActivity event type routing to verify all
EventType cases in the switch statement dispatch to the correct
formatting functions.
@mwbrooks mwbrooks added this to the Next Release milestone Mar 19, 2026
@mwbrooks mwbrooks self-assigned this Mar 19, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.23%. Comparing base (8b31c6a) to head (b074120).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   68.62%   69.23%   +0.60%     
==========================================
  Files         218      218              
  Lines       18162    18162              
==========================================
+ Hits        12464    12574     +110     
+ Misses       4538     4419     -119     
- Partials     1160     1169       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review March 19, 2026 21:41
@mwbrooks mwbrooks requested a review from a team as a code owner March 19, 2026 21:41
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Amazing again and again! With the changes of #419 we're so close to unlocking 70% praises.

🧪 All things LGTM to me so merge when time seems good to you.

}
}

func Test_prettifyActivity_allEventTypes(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 praise: Nice test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants