Skip to content

build: use minimum support @types/node@18 in development #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimeg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: use minimum support @types/node@18 in development #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36b40f
build: use minimum support @types/node@18 in development
zimeg Mar 3, 2026
76e02e3
test: use @types/node@18 in development when exporting a range
zimeg Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/vast-drinks-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@slack/logger": patch
---

build: remove @types/node from required dependencies
7 changes: 7 additions & 0 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,19 @@
"Bash(gh pr status:*)",
"Bash(gh pr update-branch:*)",
"Bash(gh pr view:*)",
"Bash(gh run view:*)",
"Bash(gh search code:*)",
"Bash(git diff:*)",
"Bash(git grep:*)",
"Bash(git log:*)",
"Bash(git ls-tree:*)",
"Bash(git show:*)",
"Bash(git status:*)",
"Bash(grep:*)",
"Bash(head:*)",
"Bash(jq:*)",
"Bash(ls:*)",
"Bash(node --test:*)",
"Bash(node --version:*)",
"Bash(npm --version:*)",
"Bash(npm config:*)",
Expand All @@ -27,7 +31,10 @@
"Bash(npm run build:*)",
"Bash(npm run lint:*)",
"Bash(npm run lint:fix:*)",
"Bash(npm show:*)",
"Bash(npm test:*)",
"Bash(npm version:*)",
"Bash(nvm use:*)",
"Bash(tail:*)",
"Bash(tree:*)",
"WebFetch(domain:docs.slack.dev)",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-hooks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
},
"devDependencies": {
"@types/minimist": "^1.2.5",
"@types/node": "^25.0.3",
"@types/node": "^18.19.130",
"@types/semver": "^7.5.6",
"@types/sinon": "^21.0.0",
"shx": "^0.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
},
"devDependencies": {
"@tsconfig/recommended": "^1.0.6",
"@types/node": "^25.0.3",
"@types/node": "^18.19.130",
"@types/sinon": "^21.0.0",
"cross-env": "^10.0.0",
"shx": "^0.4.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,8 @@
"test:node18": "npm run build && node --test --test-reporter=spec --import tsx --test src/index.test.ts",
"test:unit": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/index.test.ts"
},
"dependencies": {
"@types/node": ">=18.0.0"
},
"devDependencies": {
"@types/node": "^18.19.130",
"shx": "^0.4.0",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
Expand Down
1 change: 1 addition & 0 deletions packages/oauth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"jsonwebtoken": "^9"
},
"devDependencies": {
"@types/node": "^18.19.130",
"@types/sinon": "^21",
"rewiremock": "^3",
"shx": "^0.4.0",
Expand Down
1 change: 1 addition & 0 deletions packages/rtm-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"ws": "^8"
},
"devDependencies": {
"@types/node": "^18.19.130",
"@types/sinon": "^17",
"@types/ws": "^8",
"shx": "^0.3.2",
Expand Down
1 change: 1 addition & 0 deletions packages/socket-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"ws": "^8"
},
"devDependencies": {
"@types/node": "^18.19.130",
"@tsconfig/recommended": "^1.0.7",
"@types/proxyquire": "^1.3.31",
"@types/sinon": "^21",
Expand Down
3 changes: 2 additions & 1 deletion packages/web-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"dependencies": {
"@slack/logger": "^4.0.0",
"@slack/types": "^2.20.0",
"@types/node": ">=18.0.0",
"@types/node": ">=18",
"@types/retry": "0.12.0",
"axios": "^1.13.5",
"eventemitter3": "^5.0.1",
Expand All @@ -65,6 +65,7 @@
"devDependencies": {
"@tsconfig/recommended": "^1",
"@types/busboy": "^1.5.4",
"@types/node": "^18.19.130",
"@types/sinon": "^21",
"busboy": "^1",
"nock": "^14",
Expand Down
3 changes: 2 additions & 1 deletion packages/webhook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@
},
"dependencies": {
"@slack/types": "^2.9.0",
"@types/node": ">=18.0.0",
"@types/node": ">=18",
"axios": "^1.13.5"
},
"devDependencies": {
"@types/node": "^18.19.130",
"nock": "^14.0.6",
"shx": "^0.4.0",
"tsx": "^4.20.6",
Expand Down