-
Notifications
You must be signed in to change notification settings - Fork 676
chore: add opt-in pre-commit lint --write hook #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
035fcec
chore: add opt-in pre-commit lint --write hook
zi0w 486177f
chore: simplify pre-commit hook
zi0w b3cea66
chore: show lint output in pre-commit hook
zi0w e1468e1
chore: simplify pre-commit hook to run root lint
zi0w 92a4d49
Merge branch 'main' into chore/precommit-lint-write
zi0w 46de521
Merge branch 'main' into chore/precommit-lint-write
zi0w 0ab7188
chore: normalize pre-commit hook header
zi0w c4e2465
docs: move pre-commit hook to tasks section
zi0w 633256c
Merge branch 'main' into chore/precommit-lint-write
zi0w eda1fdc
Merge branch 'main' into chore/precommit-lint-write
zi0w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/usr/bin/env bash | ||
| set -e | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this implementation is very complex - is there a way we could simplify this? |
||
| cd "$(git rev-parse --show-toplevel)" || exit 1 | ||
| npm run lint | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ question: Would moving this to the paths following be better for organization or is ".githooks" standard for discovering these scripts?