fix: Remove 'agent: BoltAgent' listener argument#1466
Open
WilliamBergamin wants to merge 2 commits intomainfrom
Open
fix: Remove 'agent: BoltAgent' listener argument#1466WilliamBergamin wants to merge 2 commits intomainfrom
WilliamBergamin wants to merge 2 commits intomainfrom
Conversation
WilliamBergamin
added
area:async
area:sync
semver:patch
experiment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 91.43% 91.31% -0.12%
==========================================
Files 232 229 -3
Lines 7340 7266 -74
==========================================
- Hits 6711 6635 -76
- Misses 629 631 +2 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@lukegalbraithrussell when this merges then I think we are in the clear to remove the agent experiment form the docs 🙏 |
WilliamBergamin
changed the title
zimeg
approved these changes
Mar 20, 2026
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM and -1435 is cool 🪓 ✨
|
|
||
| ### Kwargs Injection | ||
|
|
||
| Listeners receive arguments by parameter name. The framework inspects function signatures and injects matching args: `body`, `event`, `action`, `command`, `payload`, `context`, `client`, `ack`, `say`, `respond`, `logger`, `complete`, `fail`, `agent`, etc. Defined in `slack_bolt/kwargs_injection/args.py`. |
Member
There was a problem hiding this comment.
💡 praise: Nice call to update this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent class was introduced as an experimental feature, the team has decided to remove it in favor of offering better top level Bolt support for "agent" features.
This PR aims to remove the experimental agent class and its references
Testing
Unit tests should be sufficient 🤔
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.