Fix all problems from PHPStan

[szepeviktor]

All things fixed, even broken greg.php 👍

@acobster Please help me in the last one:

 ------ -----------------------------------------------------------
  Line   src/api.php
 ------ -----------------------------------------------------------
  122    Cannot call method to_array() on array<int, Timber\Post>.
  127    Cannot call method to_array() on array<int, Timber\Post>.
 ------ -----------------------------------------------------------

[szepeviktor]

BTW Tests were moved from test to tests - so CI may brake, please see the other PR #1

[szepeviktor]

@acobster Just put list<\Timber\Post> here.

[szepeviktor]

it means array<int, \Timber\Post>

[acobster]

Good to know, but array<int, \Timber\Post> is not quite correct, is it? Wouldn't array<\Timber\Post> be better?

[szepeviktor]

Oh yes.

[acobster]

Unfortunately the return type for Timber::get_posts() is still annotated as array|bool|null, but should be \Timber\PostCollectionInterface|false. That will be addressed upstream in timber/timber#1863 relatively soon, so let's leave this open until then.

[szepeviktor]

Okay!!

[szepeviktor]

Cannot call method to_array() on array|true.

Still seems to be already an array thus not possible to call that method on it.

[acobster]

I think it's complaining because of the Timber type annotation array|bool|null. false and null are precluded by the ternary:

return $posts ? $posts->to_array() : [];

...but PHPStan still considers it possible it will return true. That's why we need to update Timber.

If posts are found, ::get_posts() returns a PostCollectionInterface which has a to_array() method.

[szepeviktor]

I see!!

So /** @var \Timber\PostCollectionInterface|false $post */

[szepeviktor]

Here is the Anti-Problem Laser Gun 🔫
https://twitter.com/szepeviktor/status/1324135927975940096

Now it is very easy to resolve these kind of problems.