Draft
Conversation
dmsnell
reviewed
Jul 16, 2025
| - Most commonly used selector types | ||
| - Cases with highest memory usage | ||
| - Scenarios with slowest throughput | ||
| - Error handling paths that are frequently exercised No newline at end of file |
Collaborator
There was a problem hiding this comment.
the tests are fine, but this long-winded and fluffy README is annoying me in its lack of substance. can we nix it completely, or start over with one that is information dense?
Owner
Author
There was a problem hiding this comment.
To be clear, this was entirely done by AI and I haven't invested any time in vetting anything here, I've only superficially scanned it and have no intention of proceeding until I spend some time going through this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.