Add optional DisplayTitle prop for TabContainer tabs
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a plugin I needed a tab within a
TabContainerto change its text dynamically based on some state. This is not easy to do at the moment withTabContainerand would involve juggling key names and making sure the currently selected tab state is updated to match the new key name whenever your tab would depend on some state to define its display text.I've added a
DisplayTitleprop to theTabContainerchildren tabs which will be checked for before resorting to using the child key as the display title. No changes have been made to the key being used as the identifer that is passed toOnTabSelected.