Add python UDF helpers #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesmit13
requested changes
Apr 22, 2025
Collaborator
kesmit13
left a comment
kesmit13
left a comment
There was a problem hiding this comment.
I have a few requested changes. I'm not clear on what the ConnectionInfo class is for and what makes the PythonUdfConnectionInfo different.
| valid_values=['managed', 'remote', 'collocated'], | ||
| ), | ||
| 'remote', | ||
| 'managed', |
Collaborator
There was a problem hiding this comment.
I would leave the default as remote and set it explicitly to that in the application code. This app needs to run on-prem as well and the typical way is done using remote.
| url: Optional[str] = None, | ||
| data_format: str = 'rowdat_1', | ||
| app_mode: str = 'remote', | ||
| app_mode: str = 'managed', |
| 'external_function.url', 'string', check_str, 'http://localhost:8000/invoke', | ||
| 'Specifies the URL of the external function application.', | ||
| environ=['SINGLESTOREDB_EXT_FUNC_URL'], | ||
| environ=['SINGLESTOREDB_EXT_FUNC_URL' ], |
|
|
||
|
|
||
| @dataclass | ||
| class PythonUdfAppConfig: |
Collaborator
There was a problem hiding this comment.
I think naming this UDFAppConfig would be better. Since there is no other option than Python. Udf is a bit too Java-esque. I prefer UDF .
| token: Optional[str] | ||
|
|
||
| @dataclass | ||
| class PythonUdfConnectionInfo: |
Collaborator
Author
|
Closing this Pull request, created this one instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR