-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor UDF server and external function type system #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umpy fixed strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
singlestoredb/tests/test_ext_func.py:1150
- Renaming test functions to start with an underscore may cause them to be skipped by the test runner. Confirm if this change is intentional.
def _test_varchar_mult(self):
singlestoredb/functions/ext/asgi.py:271
- The indexing with out[0][0] to determine the length for row_ids may be unreliable if the structure of 'out' changes. Verify that this logic correctly reflects the number of result rows.
row_ids = array_cls([row_ids[0]] * len(out[0][0]))
accel.c:3920
- [nitpick] Verify that allowing NUMPY_FIXED_STRING along with NUMPY_OBJECT for character output types is correct according to the intended binary data handling.
if (col_types[i].type != NUMPY_OBJECT && col_types[i].type != NUMPY_FIXED_STRING) {
…ry; test no args / no return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.