Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions MIGRATION-GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,21 @@ Use the new versioned API under `voice().v1()` to get access to [VoiceService](h

### [`Verification`](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/package-summary.html)

#### Replacement APIs

Use the new versioned API under `verification().v1()` to get access to [VerificationService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationService.html): [`sinchClient.verification().v1()`](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/VerificationService.html#v1())

| Old interface | New Equivalent in `verification().v1()` |
|---------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| verifications() `start` related APIs | [v1().verificationStart()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationStartService.html) |
| verifications() `report` related APIs | [v1().verificationReport()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationReportService.html) |
| verificationStatus() | [v1().verificationStatus()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationStatusService.html) |
| webhooks() | [v1().webhooks()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/WebHooksService.html) |
| VerificationStartService | [VerificationsStartService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationsStartService.html) |
| VerificationReportService | [VerificationsReportService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationsReportService.html) |
| VerificationStatusService | [VerificationsStatusService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationsStatusService.html) |
| WebHooksService | [WebhooksService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/WebhooksService.html) |

#### Replacement models
##### Common Report

Expand Down Expand Up @@ -442,13 +457,3 @@ Use the new versioned API under `voice().v1()` to get access to [VoiceService](h
- `VerificationMethod.DATA` enum no longer defined. No need to be replaced because not public definition is required.
- `template` field removed from `VerificationStartRequestSms`.

#### Replacement APIs

Use the new versioned API under `verification().v1()` to get access to [VerificationService](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationService.html): [`sinchClient.verification().v1()`](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/VerificationService.html#v1())

| Old interface | New Equivalent in `verification().v1()` |
|---------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| verifications() `start` related APIs | [v1().verificationStart()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationStartService.html) |
| verifications() `report` related APIs | [v1().verificationReport()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationReportService.html) |
| verificationStatus() | [v1().verificationStatus()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/VerificationStatusService.html) |
| webhooks() | [v1().webhooks()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/verification/api/v1/WebHooksService.html) |
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ public class VerificationService implements com.sinch.sdk.domains.verification.V

private final com.sinch.sdk.domains.verification.api.v1.VerificationService v1;

static {
LocalLazyInit.init();
}

public VerificationService(
ApplicationCredentials credentials,
VerificationContext context,
Expand All @@ -26,20 +22,4 @@ public VerificationService(
public com.sinch.sdk.domains.verification.api.v1.VerificationService v1() {
return this.v1;
}

static final class LocalLazyInit {

private LocalLazyInit() {
IdentityMapper.initMapper();
}

public static LocalLazyInit init() {
return LocalLazyInit.LazyHolder.INSTANCE;
}

private static class LazyHolder {

public static final LocalLazyInit INSTANCE = new LocalLazyInit();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public interface VerificationService {
* href="https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verifications">Documentation</a>
* @since 1.1
*/
VerificationStartService verificationStart();
VerificationsStartService verificationStart();

/**
* Verifications Report Service instance
Expand All @@ -27,7 +27,7 @@ public interface VerificationService {
* href="https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verifications">Documentation</a>
* @since 1.1
*/
VerificationReportService verificationReport();
VerificationsReportService verificationReport();

/**
* Verifications Status Service instance
Expand All @@ -37,7 +37,7 @@ public interface VerificationService {
* href="https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verification-status">Documentation</a>
* @since 1.1
*/
VerificationStatusService verificationStatus();
VerificationsStatusService verificationStatus();

/**
* Webhooks helpers instance
Expand All @@ -47,5 +47,5 @@ public interface VerificationService {
* href="https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verification-callbacks">Documentation</a>
* @since 1.1
*/
WebHooksService webhooks();
WebhooksService webhooks();
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
* <p>Callback events are used to authorize and manage your verification requests and return
* verification results.
*
* <p>see <a
* <p>See <a
* href="https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verification-callbacks/#tag/Verification-callbacks/paths/VerificationRequestEvent/post">https://developers.sinch.com/docs/verification/api-reference/verification/tag/Verification-callbacks/#tag/Verification-callbacks/paths/VerificationRequestEvent/post</a>
*
* @since 1.1
*/
public interface WebHooksService {
public interface WebhooksService {

/**
* The Sinch Platform can initiate callback requests to a URL you define (Callback URL) on request
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@
import com.sinch.sdk.auth.adapters.BasicAuthManager;
import com.sinch.sdk.core.http.AuthManager;
import com.sinch.sdk.core.http.HttpClient;
import com.sinch.sdk.core.http.HttpMapper;
import com.sinch.sdk.core.utils.StringUtil;
import com.sinch.sdk.domains.verification.adapters.IdentityMapper;
import com.sinch.sdk.domains.verification.api.v1.VerificationsReportService;
import com.sinch.sdk.domains.verification.api.v1.VerificationsStartService;
import com.sinch.sdk.domains.verification.api.v1.VerificationsStatusService;
import com.sinch.sdk.domains.verification.models.v1.report.response.VerificationReportResponseMapper;
import com.sinch.sdk.domains.verification.models.v1.start.response.VerificationStartResponseMapper;
import com.sinch.sdk.domains.verification.models.v1.status.response.VerificationStatusResponseMapper;
import com.sinch.sdk.models.ApplicationCredentials;
import com.sinch.sdk.models.VerificationContext;
import java.util.Map;
Expand All @@ -28,10 +35,10 @@ public class VerificationService

private final VerificationContext context;
private final Supplier<HttpClient> httpClientSupplier;
private volatile VerificationStartService startService;
private volatile VerificationReportService reportService;
private volatile VerificationStatusService statusService;
private volatile WebHooksService webhooks;
private volatile VerificationsStartService startService;
private volatile VerificationsReportService reportService;
private volatile VerificationsStatusService statusService;
private volatile WebhooksService webhooks;

private volatile Map<String, AuthManager> clientAuthManagers;
private volatile Map<String, AuthManager> webhooksAuthManagers;
Expand Down Expand Up @@ -77,37 +84,49 @@ private void createAuthManagers(ApplicationCredentials credentials) {
APPLICATION_SECURITY_SCHEME_KEYWORD_VERIFICATION, applicationAuthManager);
}

public VerificationStartService verificationStart() {
public VerificationsStartService verificationStart() {
if (null == this.startService) {
instanceLazyInit();
this.startService =
new VerificationStartService(context, httpClientSupplier.get(), clientAuthManagers);
new VerificationsStartServiceImpl(
httpClientSupplier.get(),
context.getVerificationServer(),
clientAuthManagers,
HttpMapper.getInstance());
}
return this.startService;
}

public VerificationReportService verificationReport() {
public VerificationsReportService verificationReport() {
if (null == this.reportService) {
instanceLazyInit();
this.reportService =
new VerificationReportService(context, httpClientSupplier.get(), clientAuthManagers);
new VerificationsReportServiceImpl(
httpClientSupplier.get(),
context.getVerificationServer(),
clientAuthManagers,
HttpMapper.getInstance());
}
return this.reportService;
}

public VerificationStatusService verificationStatus() {
public VerificationsStatusService verificationStatus() {
if (null == this.statusService) {
instanceLazyInit();
this.statusService =
new VerificationStatusService(context, httpClientSupplier.get(), clientAuthManagers);
new VerificationsStatusServiceImpl(
httpClientSupplier.get(),
context.getVerificationServer(),
clientAuthManagers,
HttpMapper.getInstance());
}
return this.statusService;
}

public WebHooksService webhooks() {
public WebhooksService webhooks() {
if (null == this.webhooks) {
instanceLazyInit();
this.webhooks = new WebHooksService(webhooksAuthManagers);
this.webhooks = new WebhooksService(webhooksAuthManagers);
}
return this.webhooks;
}
Expand Down Expand Up @@ -147,6 +166,9 @@ static final class LocalLazyInit {

private LocalLazyInit() {
IdentityMapper.initMapper();
VerificationStartResponseMapper.initMapper();
VerificationStatusResponseMapper.initMapper();
VerificationReportResponseMapper.initMapper();
}

public static LocalLazyInit init() {
Expand Down
Loading
Loading