Skip to content

fix(md-render): inline code inherits heading size in mothership/templates/changelog#4504

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/md-header-fix
May 8, 2026
Merged

fix(md-render): inline code inherits heading size in mothership/templates/changelog#4504
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/md-header-fix

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Drop hardcoded text-small/text-xs on inlineCode in mothership chat (also covers copilot side panel), template detail page, and changelog renderer so inline code inherits the surrounding heading size
  • Add whitespace-normal and not-italic to mirror the file-viewer fix from fix(md-render): fix markdown rendering in file viewer #4458

Type of Change

  • Bug fix

Testing

Tested manually — setstate in mothership chat headings now matches header size

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 8, 2026 0:15am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 8, 2026

PR Summary

Low Risk
Low risk styling-only change to markdown renderers; affects how inlineCode wraps and inherits typography but does not touch data, auth, or business logic.

Overview
Fixes markdown inlineCode rendering across chat, template details, and changelog so inline code inherits surrounding font size (e.g., headings) instead of forcing text-xs/text-small.

Also aligns inline code styling by adding whitespace-normal and not-italic, improving wrapping and preventing italicized code in these renderers.

Reviewed by Cursor Bugbot for commit 1f951cb. Configure here.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 8, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Greptile Summary

This PR removes hardcoded text-xs / text-small Tailwind size classes from inlineCode renderers in the mothership chat, template detail page, and changelog timeline, replacing them with whitespace-normal and not-italic so inline code inherits the surrounding heading's font size — matching the fix already applied to the file-viewer in #4458.

  • chat-content.tsx: drops text-small, adds whitespace-normal not-italic so inlineCode in mothership/copilot headings scales with the heading.
  • template.tsx & timeline-list.tsx: same treatment — drop text-xs, add whitespace-normal not-italic.
  • note-block.tsx (unchanged in this PR) has the same pre-fix pattern (text-xs without not-italic) and may be worth updating for full consistency.

Confidence Score: 5/5

Safe to merge — pure Tailwind class swap with no logic changes, consistently mirroring the file-viewer fix already in production.

All three changes are identical in nature: removing a hardcoded font-size class and adding whitespace-normal not-italic. No component logic, state, or props are touched. The pattern is already validated in the file-viewer component from #4458.

No files in this PR require special attention. note-block.tsx (not changed here) has the same pre-fix pattern and could benefit from a follow-up.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-content.tsx Removes hardcoded text-small font-size class from inlineCode; adds whitespace-normal and not-italic so inline code inherits heading size in mothership chat.
apps/sim/app/templates/[id]/template.tsx Removes hardcoded text-xs from inlineCode; adds whitespace-normal and not-italic to match the file-viewer pattern, allowing font-size inheritance in template detail headings.
apps/sim/app/changelog/components/timeline-list.tsx Removes hardcoded text-xs from inlineCode; adds whitespace-normal and not-italic so inline code in changelog headings inherits surrounding heading size.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Markdown Renderer] --> B{Component type?}
    B -->|inlineCode| C[code element]
    C --> D[Old: hardcoded text-xs / text-small]
    C --> E[New: inherits parent font-size]
    E --> F[whitespace-normal]
    E --> G[not-italic]
    E --> H[No font-size override → inherits heading size]
    subgraph Locations Fixed
        L1[chat-content.tsx mothership / copilot]
        L2[template.tsx template detail page]
        L3[timeline-list.tsx changelog]
    end
    subgraph Still Uses text-xs
        L4[note-block.tsx note block renderer]
    end
Loading

Reviews (2): Last reviewed commit: "fix(md-render): inline code inherits hea..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/md-header-fix branch from 263ecf9 to 1f951cb Compare May 8, 2026 00:15
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1f951cb. Configure here.

@waleedlatif1 waleedlatif1 merged commit 408669d into staging May 8, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/md-header-fix branch May 8, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant