Skip to content

fix(files): skip zip and return plain .md when no embedded images #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
May 7, 2026
+14 −1
Merged

fix(files): skip zip and return plain .md when no embedded images #4498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b49c0f3
fix(files): skip zip and return plain .md when no embedded images
waleedlatif1 May 7, 2026
807190d
fix(files): use imageIds.length guard instead of assetMap.size
waleedlatif1 May 7, 2026
26edc0c
fix(files): move imageIds.length guard before async fetch to avoid un…
waleedlatif1 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/sim/app/api/files/export/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,20 @@ export const GET = withRouteHandler(
MAX_EMBEDDED_IMAGES
)

logger.info('Exporting markdown with embedded images', { id, imageCount: imageIds.length })
logger.info('Exporting markdown', { id, imageCount: imageIds.length })

if (imageIds.length === 0) {
const mdName = safeFilename(record.originalName)
const mdBytes = Buffer.from(mdContent, 'utf-8')
return new NextResponse(new Uint8Array(mdBytes), {
status: 200,
headers: {
'Content-Type': 'text/markdown; charset=utf-8',
'Content-Disposition': `attachment; filename="${mdName}"`,
'Content-Length': String(mdBytes.length),
},
})
}

const fetchResults = await Promise.allSettled(
imageIds.map(async (imageId) => {
Expand Down
Loading