Skip to content

fix(executor): strip childTraceSpans from block state before LLM tool calls #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
May 4, 2026
Merged

fix(executor): strip childTraceSpans from block state before LLM tool calls #4428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839ad2f
fix(executor): strip childTraceSpans from block state before LLM tool…
waleedlatif1 May 4, 2026
293c1f9
fix(executor): return stripped output so orchestrator setBlockOutput …
waleedlatif1 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/sim/executor/execution/block-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ export class BlockExecutor {
}
}

this.state.setBlockOutput(node.id, normalizedOutput, duration)
const { childTraceSpans: _traces, ...outputForState } = normalizedOutput
this.state.setBlockOutput(node.id, outputForState as NormalizedBlockOutput, duration)
Comment thread
waleedlatif1 marked this conversation as resolved.

if (!isSentinel && blockLog) {
const childWorkflowInstanceId =
Expand All @@ -211,7 +212,7 @@ export class BlockExecutor {
)
}

return normalizedOutput
return outputForState as NormalizedBlockOutput
} catch (error) {
return await this.handleBlockError(
error,
Expand Down Expand Up @@ -270,7 +271,6 @@ export class BlockExecutor {
}

if (ChildWorkflowError.isChildWorkflowError(error)) {
errorOutput.childTraceSpans = error.childTraceSpans
errorOutput.childWorkflowName = error.childWorkflowName
if (error.childWorkflowSnapshotId) {
errorOutput.childWorkflowSnapshotId = error.childWorkflowSnapshotId
Expand All @@ -287,8 +287,8 @@ export class BlockExecutor {
blockLog.input = this.sanitizeInputsForLog(input)
blockLog.output = filterOutputForLog(block.metadata?.id || '', errorOutput, { block })

if (errorOutput.childTraceSpans && Array.isArray(errorOutput.childTraceSpans)) {
blockLog.childTraceSpans = errorOutput.childTraceSpans
if (ChildWorkflowError.isChildWorkflowError(error) && error.childTraceSpans.length > 0) {
blockLog.childTraceSpans = error.childTraceSpans
}
}

Expand Down
Loading