Skip to content

feat(table): hide new workflow column feature#4414

Merged
TheodoreSpeaks merged 4 commits intostagingfrom
fix/disable-table-trigger
May 3, 2026
Merged

feat(table): hide new workflow column feature#4414
TheodoreSpeaks merged 4 commits intostagingfrom
fix/disable-table-trigger

Conversation

@TheodoreSpeaks
Copy link
Copy Markdown
Collaborator

@TheodoreSpeaks TheodoreSpeaks commented May 3, 2026

Summary

Temporarily hide workflow column feature to unblock staging. Also reverted the copilot type contract so mothership doesn't try to create one.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • Checked locally, validated no way to create workflow column.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

@vercel
Copy link
Copy Markdown

vercel Bot commented May 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 3, 2026 1:18am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Medium risk because it changes both UI column-type availability and the Copilot user_table tool contract by removing workflow-group operations/args, which could break any callers relying on those capabilities.

Overview
Workflow columns are no longer creatable via the column sidebar UI: the workflow type option is filtered out unless editing an existing workflow-backed column/group.

Copilot contract rollback: the generated user_table tool catalog/schemas remove workflow-group related operations and parameters (e.g., add_workflow_group, run_workflow_group, deps/outputs fields), narrowing the surface area exposed to agents.

Test stability: readFileRecord image tests that exercise sharp now use a longer per-test timeout to reduce CI flakes.

Reviewed by Cursor Bugbot for commit 7523570. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 3, 2026

Greptile Summary

This PR temporarily hides the workflow column feature to unblock staging: the column-type picker now filters out workflow unless an existing workflow group is already bound to the column, and all workflow-group copilot operations are removed from the generated tool catalog and schema files.

  • P1: mapping.additionalProperties.type was narrowed from ['string', 'null'] to 'string' in both tool-catalog-v1.ts and tool-schemas-v1.ts, but both files' descriptions still instruct the copilot to pass null to skip a CSV column — any such call will fail schema validation.

Confidence Score: 3/5

Not safe to merge without fixing the mapping schema mismatch that breaks null-skip for CSV import via copilot.

One P1 defect (schema type contradicts the description it ships alongside) keeps the ceiling at 4/5, and it affects an active non-workflow code path (CSV import), pulling the score to 3/5.

apps/sim/lib/copilot/generated/tool-catalog-v1.ts and apps/sim/lib/copilot/generated/tool-schemas-v1.ts — the mapping.additionalProperties.type must be restored to ['string', 'null'] or the description updated to remove the null instruction.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-sidebar/column-sidebar.tsx Filters the 'workflow' type out of the column-type picker unless an existing workflow group is present; dependency added to useMemo correctly.
apps/sim/lib/copilot/generated/tool-catalog-v1.ts Removes all workflow-group copilot operations; introduces a schema/description mismatch on the mapping field (type narrowed to 'string' but description still allows null) and drops items spec from rowIds.
apps/sim/lib/copilot/generated/tool-schemas-v1.ts Bulk reformatting (unquoted to quoted keys, single to double quotes) plus removal of workflow-group parameters from user_table schema; carries the same mapping null-type mismatch as tool-catalog-v1.ts.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User opens Column Sidebar] --> B{existingGroup?}
    B -- Yes --> C[Show all type options including workflow]
    B -- No --> D[Filter out workflow type option]
    C --> E[User selects type]
    D --> E
    E --> F{type === workflow?}
    F -- Yes --> G[Show workflow config UI]
    F -- No --> H[Show scalar column UI]

    I[Copilot: import_file with mapping] --> J{mapping value null?}
    J -- Yes --> K[Schema validation fails - type string rejects null]
    J -- No --> L[Maps CSV header to column]
Loading

Reviews (1): Last reviewed commit: "fix lint" | Re-trigger Greptile

Comment thread apps/sim/lib/copilot/generated/tool-catalog-v1.ts
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1fbac96. Configure here.

Comment thread apps/sim/lib/copilot/generated/tool-catalog-v1.ts
Comment thread apps/sim/lib/copilot/generated/tool-catalog-v1.ts
@TheodoreSpeaks TheodoreSpeaks merged commit 71ebe81 into staging May 3, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/disable-table-trigger branch May 3, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant