improvement(sidebar): overlay lock indicator on leading icon#4412
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The lock icon now fades out on hover (and when the context menu is open) while the options button fades in and only becomes clickable on hover/context-menu-open via Reviewed by Cursor Bugbot for commit 90abdb4. Configure here. |
Greptile SummaryThis PR relocates the lock indicator on sidebar workflow and folder items from an inline position (next to the name) into the trailing 18 × 18 px slot already occupied by the "More options" button. The two icons cross-fade on hover using Confidence Score: 5/5Safe to merge — only a P2 style/completeness gap (missing Tooltip) relative to the PR description; no runtime errors or logic bugs. All previously flagged issues (invalid HTML nesting, keyboard accessibility, event bubbling) have been addressed. The remaining gap is the emcn Tooltip described in the PR spec but not implemented, which is a P2 completeness issue that does not affect correctness or accessibility for the current release. Both changed files have the same Tooltip omission; no other files require attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Sidebar Item Row] --> B[Leading Icon\nColor Swatch / Folder Icon]
A --> C[Content Area\nName + Avatars]
A --> D[Trailing Slot\n18x18px relative container]
D --> E{item.locked?}
E -- Yes --> F[Lock span\nrole=img, aria-label\npointer-events-none]
E -- No --> G[slot empty]
D --> H[More Button\npointer-events-none by default]
F --> I{Hover / Context Menu open?}
I -- Yes --> J[Lock opacity to 0\nMore button opacity to 1\nMore pointer-events auto]
I -- No --> K[Lock opacity = 1\nMore button opacity = 0]
Reviews (4): Last reviewed commit: "fix(sidebar): add role=img so lock indic..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 90abdb4. Configure here.
Summary
Tooltipwith a "Locked" label and use design tokens (--surface-1knockout,--text-icon)Type of Change
Testing
Tested manually
Checklist