fix(executor): condition inside parallel

[icecrasher321]

Summary

Condition blocks inside parallels.

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jan 31, 2026 1:53am

[icecrasher321]

@cursor review

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed condition blocks to work correctly inside parallel branches by handling virtual block IDs with subscript notation (e.g., blockId₍0₎).

Key Changes:

• Modified condition-handler.ts to extract base block IDs for connection lookups while resolving virtual source block IDs for the same branch context
• Enhanced collectBlockData to pass currentNodeId parameter and map branch-specific block states to base IDs for proper variable resolution
• Added comprehensive test coverage with 3 new test cases validating condition evaluation across different parallel branches

How it works:
When a condition block executes inside a parallel branch (e.g., cond-block-1₍0₎):

1. The handler extracts the base ID (cond-block-1) to look up connections in the workflow definition
2. It builds the virtual source block ID for the same branch (e.g., agent-block-1₍0₎) to read the correct branch's output
3. collectBlockData maps the branch-specific data to both the virtual ID and base ID, enabling <BlockName.field> references to resolve correctly within the branch context

This ensures condition expressions evaluate using the correct data from their specific parallel branch rather than mixing data across branches.

Confidence Score: 5/5

• This PR is safe to merge with no identified issues
• The implementation correctly handles parallel branch context resolution with proper base ID extraction and virtual ID mapping. The logic is well-tested with comprehensive test cases covering multiple scenarios. The changes are focused and don't introduce breaking changes to existing functionality.
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/executor/handlers/condition/condition-handler.ts	Added parallel branch support by extracting base block IDs for connection lookups and resolving virtual source block IDs within the same branch context
apps/sim/executor/utils/block-data.ts	Enhanced collectBlockData to map branch-specific block state data to base block IDs for variable resolution in parallel contexts
apps/sim/executor/handlers/condition/condition-handler.test.ts	Added comprehensive test coverage for condition blocks executing inside parallel branches with virtual block IDs

Sequence Diagram

sequenceDiagram
    participant Executor
    participant ConditionHandler
    participant collectBlockData
    participant subflowUtils
    participant executeTool

    Note over Executor,executeTool: Condition Block Inside Parallel Branch

    Executor->>ConditionHandler: execute(ctx, block: "cond₍0₎", inputs)
    
    Note over ConditionHandler: Extract base ID from virtual ID
    ConditionHandler->>subflowUtils: extractBaseBlockId("cond₍0₎")
    subflowUtils-->>ConditionHandler: "cond"
    
    ConditionHandler->>subflowUtils: extractBranchIndex("cond₍0₎")
    subflowUtils-->>ConditionHandler: 0
    
    Note over ConditionHandler: Find connection using base ID
    ConditionHandler->>ConditionHandler: workflow.connections.find(conn.target === "cond")
    ConditionHandler->>ConditionHandler: sourceConnection.source = "agent"
    
    Note over ConditionHandler: Build virtual source ID for same branch
    ConditionHandler->>subflowUtils: buildBranchNodeId("agent", 0)
    subflowUtils-->>ConditionHandler: "agent₍0₎"
    
    ConditionHandler->>ConditionHandler: Check blockStates.has("agent₍0₎")
    ConditionHandler->>ConditionHandler: sourceBlockId = "agent₍0₎"
    
    Note over ConditionHandler: Build evaluation context from branch data
    ConditionHandler->>ConditionHandler: buildEvaluationContext(ctx, "agent₍0₎")
    
    Note over ConditionHandler: Evaluate condition with branch context
    ConditionHandler->>collectBlockData: collectBlockData(ctx, "cond₍0₎")
    
    Note over collectBlockData: Map branch data to base IDs
    collectBlockData->>subflowUtils: isBranchNodeId("cond₍0₎")
    subflowUtils-->>collectBlockData: true
    collectBlockData->>subflowUtils: extractBranchIndex("cond₍0₎")
    subflowUtils-->>collectBlockData: 0
    
    loop For each blockState
        collectBlockData->>collectBlockData: blockData["agent₍0₎"] = state.output
        collectBlockData->>subflowUtils: isBranchNodeId("agent₍0₎") && branchIndex === 0
        subflowUtils-->>collectBlockData: true
        collectBlockData->>subflowUtils: extractBaseBlockId("agent₍0₎")
        subflowUtils-->>collectBlockData: "agent"
        collectBlockData->>collectBlockData: blockData["agent"] = state.output
    end
    
    collectBlockData-->>ConditionHandler: {blockData, blockNameMapping, blockOutputSchemas}
    
    ConditionHandler->>executeTool: function_execute(code, blockData, ...)
    executeTool-->>ConditionHandler: {success: true, output: {result: true}}
    
    Note over ConditionHandler: Find target using base ID
    ConditionHandler->>ConditionHandler: workflow.connections.find(conn.source === "cond")
    
    ConditionHandler-->>Executor: {conditionResult: true, selectedPath, selectedOption}

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR