-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ee): access control, sso #3061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR consolidates enterprise features (Access Control and SSO) into a dedicated Key Changes:
Architecture Impact: Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UI as Settings UI
participant API as Backend API
participant DB as Database
participant Executor
Note over User,Executor: Access Control Configuration
User->>UI: Configure permission group
UI->>API: Create permission group
API->>DB: Store group config
DB-->>UI: Group created
UI->>API: Add members
API->>DB: Link users to group
DB-->>UI: Members added
Note over User,Executor: SSO Configuration
User->>UI: Setup SSO provider
UI->>API: Register provider
API->>DB: Save OIDC or SAML config
DB-->>UI: Provider configured
User->>API: Login via SSO
API->>DB: Lookup provider
API->>API: Authenticate via IdP
API->>DB: Create session
API-->>User: Authenticated
Note over User,Executor: Runtime Permission Validation
User->>Executor: Run workflow
Executor->>DB: Get permission config
DB-->>Executor: Config retrieved
Executor->>Executor: Validate models
Executor->>Executor: Validate blocks
alt Not permitted
Executor-->>User: Error
else Permitted
Executor-->>User: Success
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 1 comment
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/sim/ee/sso/components/sso.tsx
Line: 20:61
Comment:
duplicate constant `TRUSTED_SSO_PROVIDERS` already exists in `constants.ts` as `SSO_TRUSTED_PROVIDERS`
```suggestion
// Remove this duplicate - import from constants instead:
// import { SSO_TRUSTED_PROVIDERS } from '@/ee/sso/lib/constants'
```
How can I resolve this? If you propose a fix, please make it concise. |
|
@cursor review |
Summary
Brief description of what this PR does and why.
Fixes #(issue)
Type of Change
Testing
How has this been tested? What should reviewers focus on?
Checklist
Screenshots/Videos