Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • update strokeWidth of action bar items to match, update run from block icon to match run workflow button
  • update docs, remove outdated ss

Type of Change

  • Bug fix

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 29, 2026 0:13am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR updates icon styling for visual consistency in the workflow action bar and refreshes documentation with updated screenshots.

Key Changes

  • Icon consistency: Replaced lucide Play with custom PlayOutline icon in action bar for consistent stroke width across all action buttons
  • New icon component: Added PlayOutline to EMCN library with 24x24 viewBox and strokeWidth 2, matching lucide icon standards
  • Documentation updates: Added "Run from block" and "Run until block" entries with new screenshots, updated "Filter logs" description and screenshots

Technical Details

The PR creates a stroke-based play icon (PlayOutline) that maintains visual consistency with other lucide icons (ArrowLeftRight, ArrowUpDown, Circle, etc.) used in the action bar. All icons now share the same strokeWidth (2) and viewBox (24x24) standards, ensuring uniform appearance when scaled to h-[11px] w-[11px].

Documentation changes improve user guidance by clarifying the filter logs workflow and documenting the run from/until block features with updated screenshots reflecting the current UI.

Confidence Score: 5/5

  • This PR is safe to merge with no issues - purely visual consistency improvements and documentation updates
  • All changes are non-breaking visual improvements: new icon component follows established patterns, action bar properly imports and uses the new icon, and documentation accurately reflects current features
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/components/emcn/icons/play.tsx Added new PlayOutline icon component with stroke/outline version matching lucide style (24x24 viewBox, strokeWidth 2)
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/action-bar/action-bar.tsx Replaced lucide Play icon with PlayOutline from EMCN library for consistent styling in action bar
apps/docs/content/docs/en/quick-reference/index.mdx Added documentation for "Run from block" and "Run until block" features, updated filter logs description

Sequence Diagram

sequenceDiagram
    participant User
    participant ActionBar
    participant PlayOutline as PlayOutline Icon
    participant EMCN as EMCN Library
    
    Note over User,EMCN: Icon Consistency Update Flow
    
    User->>ActionBar: Hover over workflow block
    ActionBar->>ActionBar: Display action buttons
    ActionBar->>PlayOutline: Render "Run from block" button
    Note over PlayOutline: strokeWidth: 2<br/>viewBox: 24x24<br/>Matches lucide style
    PlayOutline->>EMCN: Import from @/components/emcn
    Note over EMCN: Replaced lucide Play<br/>with custom PlayOutline
    EMCN-->>ActionBar: Render with ICON_SIZE (11px)
    ActionBar-->>User: Display consistent icon styling
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit 0c0f19c into staging Jan 29, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/icon branch January 29, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants