improvement(modal): fixed popover issue in custom tools modal, removed the ability to update if no changes made#2897
Merged
waleedlatif1 merged 6 commits intostagingfrom Jan 20, 2026
Conversation
…d the ability to update if no changes made
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR fixes popover keyboard navigation issues when input fields are focused and adds change tracking to the custom tool modal to prevent accidental data loss. Key Changes:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CustomToolModal
participant PopoverContent
participant ValidationSystem
participant ChangeTracking
User->>CustomToolModal: Opens modal (new or edit)
CustomToolModal->>ChangeTracking: Store initial values
User->>CustomToolModal: Types in schema editor
CustomToolModal->>PopoverContent: Shows parameter dropdown
PopoverContent->>PopoverContent: Check if input focused
Note over PopoverContent: New: Skip keyboard nav if input focused
User->>PopoverContent: Presses Arrow/Enter/Space
PopoverContent->>CustomToolModal: Navigate/select parameter
CustomToolModal->>CustomToolModal: Insert parameter
User->>CustomToolModal: Modifies schema/code
CustomToolModal->>ValidationSystem: Validate schema
ValidationSystem->>CustomToolModal: Return validation result
CustomToolModal->>ChangeTracking: Check for changes
ChangeTracking->>CustomToolModal: Enable/disable save button
User->>CustomToolModal: Attempts to close
CustomToolModal->>ChangeTracking: Check hasUnsavedChanges
alt Has unsaved changes
CustomToolModal->>User: Show discard alert
User->>CustomToolModal: Confirm or cancel
else No unsaved changes
CustomToolModal->>User: Close immediately
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
...omponents/sub-block/components/tool-input/components/custom-tool-modal/custom-tool-modal.tsx
Outdated
Show resolved
Hide resolved
...omponents/sub-block/components/tool-input/components/custom-tool-modal/custom-tool-modal.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…d the ability to update if no changes made
Collaborator
Author
|
@greptile |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Author
|
@greptile |
...omponents/sub-block/components/tool-input/components/custom-tool-modal/custom-tool-modal.tsx
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| variant='tertiary' | ||
| onClick={handleSave} | ||
| disabled={!isSchemaValid || !!schemaError} | ||
| disabled={!isSchemaValid || !!schemaError || !hasChanges} |
There was a problem hiding this comment.
Cancel button bypasses unsaved changes confirmation
Medium Severity
The Cancel buttons call handleClose directly instead of handleCloseAttempt, bypassing the newly-added unsaved changes confirmation. This creates inconsistent behavior where pressing Escape or clicking outside shows a discard confirmation dialog, but clicking Cancel closes immediately without warning, potentially causing users to lose their work unexpectedly.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist