fix(undo-redo): preserve subblock values during undo/redo cycles#2884
Merged
waleedlatif1 merged 2 commits intostagingfrom Jan 19, 2026
Merged
fix(undo-redo): preserve subblock values during undo/redo cycles#2884waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixed critical undo/redo bug where subblock values (like code in function blocks) were lost during undo/redo cycles. Key Changes:
Technical Implementation: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Hook as use-undo-redo
participant Utils as undo-redo/utils
participant Store as WorkflowStore
participant SubBlockStore
User->>Hook: Undo batch remove operation
Hook->>Store: Get current edges
Hook->>Utils: captureLatestEdges(edges, blockIds)
Utils-->>Hook: Latest edges for blocks
Hook->>Store: Get current blocks
Hook->>Utils: captureLatestSubBlockValues(blocks, workflowId, blockIds)
Utils->>Utils: mergeSubblockState(blocks, workflowId, blockId)
Utils->>Utils: Extract non-null/undefined subblock values
Utils-->>Hook: Latest subblock values
Hook->>Hook: Update operation.data.subBlockValues
Hook->>Hook: Update inverse.data.subBlockValues
Hook->>Store: batchRemoveBlocks(blockIds)
Note over Hook,SubBlockStore: Values preserved for redo operation
User->>Hook: Redo operation
Hook->>Store: batchAddBlocks with preserved subBlockValues
Hook->>SubBlockStore: setState with subBlockValues
Note over User,SubBlockStore: Subblock values restored successfully
|
Collaborator
Author
|
@greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist