fix(wand): improved flickering for invalid JSON icon while streaming#2868
Merged
waleedlatif1 merged 1 commit intostagingfrom Jan 17, 2026
Merged
fix(wand): improved flickering for invalid JSON icon while streaming#2868waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR fixes flickering of the invalid JSON warning icon during AI streaming by conditionally hiding the icon when In
In
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SubBlock
participant Code
participant Wand
participant ValidationEffect
User->>SubBlock: Click "Generate" button
SubBlock->>Code: Trigger wand streaming
Code->>Wand: generateStream(prompt)
Wand->>Wand: setIsStreaming(true)
loop Streaming chunks
Wand->>Code: onStreamChunk(chunk)
Code->>Code: setCode(prev + chunk)
Code->>ValidationEffect: isValidJson recalculated
ValidationEffect->>ValidationEffect: Check isValid = !shouldValidateJson || isValidJson
alt JSON is valid or not validating
ValidationEffect->>SubBlock: onValidationChange(true)
SubBlock->>SubBlock: setIsValidJson(true)
Note over SubBlock: Icon hidden (!isValidJson = false)
else JSON is invalid
ValidationEffect->>ValidationEffect: setTimeout 150ms
ValidationEffect->>SubBlock: onValidationChange(false)
SubBlock->>SubBlock: setIsValidJson(false)
Note over SubBlock: Icon still hidden (isStreaming = true)
end
end
Wand->>Code: Streaming complete
Wand->>Wand: setIsStreaming(false)
Code->>ValidationEffect: Final validation
ValidationEffect->>SubBlock: onValidationChange(isValid)
SubBlock->>SubBlock: Icon now shows if invalid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
improved flickering for invalid JSON icon while streaming
Type of Change
Testing
Tested manually
Checklist