fix(sockets): webhooks logic removal from copilot ops#2862
Merged
icecrasher321 merged 2 commits intostagingfrom Jan 17, 2026
Merged
fix(sockets): webhooks logic removal from copilot ops#2862icecrasher321 merged 2 commits intostagingfrom
icecrasher321 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR completes the fix for webhook-related crashes by removing webhook preservation logic from workflow editing operations and adding stricter parameter validation.
The webhook preservation logic was causing the application to crash when editing deployed webhooks. This is a continuation of commit df8dd05 which started removing this problematic logic. Webhooks are properly managed through their CASCADE DELETE relationships with Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant EditWorkflow as edit_workflow Tool
participant WorkflowPersistence as persistence/utils
participant SocketOps as socket/operations
participant DB as Database
Client->>EditWorkflow: execute({operations, workflowId})
Note over EditWorkflow: Validate operations is array<br/>and not empty
alt operations not array or empty
EditWorkflow-->>Client: Error: operations required and must be array
end
EditWorkflow->>WorkflowPersistence: saveWorkflowToNormalizedTables()
Note over WorkflowPersistence: Start transaction
WorkflowPersistence->>DB: DELETE workflowBlocks
WorkflowPersistence->>DB: DELETE workflowEdges
WorkflowPersistence->>DB: DELETE workflowSubflows
Note over WorkflowPersistence: No webhook preservation<br/>(removed in this PR)
WorkflowPersistence->>DB: INSERT new blocks
WorkflowPersistence->>DB: INSERT new edges
WorkflowPersistence->>DB: INSERT new subflows
Note over WorkflowPersistence: Commit transaction
WorkflowPersistence-->>EditWorkflow: {success: true}
EditWorkflow->>SocketOps: handleWorkflowOperationTx(replace-state)
Note over SocketOps: Start transaction
SocketOps->>DB: DELETE workflowBlocks
SocketOps->>DB: DELETE workflowSubflows
Note over SocketOps: No webhook preservation<br/>(removed in this PR)
SocketOps->>DB: INSERT new blocks
SocketOps->>DB: INSERT new edges
SocketOps->>DB: INSERT new subflows
Note over SocketOps: Commit transaction
SocketOps-->>EditWorkflow: Success
EditWorkflow-->>Client: Modified workflow state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should not die on editing deployed webhook.
Type of Change
Testing
Tested manually
Checklist