improvement(webhooks): lifecycle management with external providers, remove save configuration #2831
Merged
icecrasher321 merged 7 commits intostagingfrom Jan 15, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant "Deploy API" as Deploy
participant "Webhook Deploy" as WH
participant "Provider Subscriptions" as PS
participant "Webhook Utils" as WU
participant Database as DB
participant "External Provider" as EP
User->>Deploy: "POST /api/workflows/{id}/deploy"
Deploy->>WH: "saveTriggerWebhooksForDeploy"
WH->>DB: "Query existing webhooks"
WH->>WH: "Determine webhooks to delete/create"
alt Webhooks to delete
WH->>PS: "cleanupExternalWebhook"
PS->>EP: "Delete webhook subscription"
WH->>DB: "Delete webhook records"
end
alt Credential Set webhooks
WH->>WU: "syncWebhooksForCredentialSet"
WU->>DB: "Create multiple webhooks"
WU->>PS: "createExternalWebhookSubscription"
PS->>EP: "Create external subscription"
end
alt Regular webhooks
WH->>PS: "createExternalWebhookSubscription"
PS->>EP: "Create external subscription"
PS-->>WH: "Updated config with external ID"
WH->>DB: "Insert webhook record"
end
alt Polling webhooks
WH->>WU: "configureGmailPolling/configureOutlookPolling"
WU->>EP: "Configure polling service"
end
WH-->>Deploy: "Success/Error result"
Deploy-->>User: "Deployment response"
|
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Will do webhook lifecycle management as part of deploy process.
Type of Change
Testing
Tested manually
Checklist