fix(otp): send welcome email even when user signs up via email/pass along with oauth providers

[waleedlatif1]

Summary

• added overrideDefaultEmailVerification: true to fix welcome email not sent for email/OTP signups
  • https://www.better-auth.com/docs/plugins/email-otp

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 15, 2026 2:43am

[greptile-apps]

Greptile Summary

This PR fixes a bug where welcome emails were not being sent to users who signed up via email/password or email/OTP authentication methods. The fix adds overrideDefaultEmailVerification: true to the emailOTP plugin configuration in apps/sim/lib/auth/auth.ts, which enables the afterEmailVerification hook to execute for all email verification flows (not just OAuth). This ensures consistent welcome email delivery across all signup methods.

• Change: Added single configuration flag to emailOTP plugin
• Impact: Welcome emails now sent to all signup methods (email/password, email/OTP, and OAuth)
• Testing: Manually tested
• Risk: Low - minimal code change, configuration-only fix aligned with better-auth plugin documentation

Confidence Score: 5/5

• This PR is safe to merge with minimal risk - it's a straightforward configuration-only fix aligned with better-auth documentation.
• Score of 5 reflects: (1) Single-line configuration change with no complex logic, (2) Fix directly addresses documented behavior in better-auth plugin, (3) No changes to critical paths or database schema, (4) Improves user experience by ensuring consistent welcome email delivery, (5) Minimal risk of side effects as it only enables an existing hook, (6) Manually tested by author.
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/lib/auth/auth.ts	Added overrideDefaultEmailVerification: true to the emailOTP plugin configuration. This enables the afterEmailVerification hook to execute for email/OTP signups, ensuring welcome emails are sent to users who sign up via email/password or email/OTP paths alongside OAuth users. The fix resolves a bug where welcome emails weren't being sent for non-OAuth signups.

Sequence Diagram

sequenceDiagram
    participant User
    participant EmailOTP as Email/OTP Plugin
    participant EmailVerif as Email Verification
    participant WelcomeEmail as Welcome Email Hook
    participant EmailService as Email Service

    rect rgba(0, 0, 255, 0.1)
    note over User,EmailService: Before Fix: overrideDefaultEmailVerification not set
    User->>EmailOTP: Sign up via Email/OTP
    EmailOTP->>EmailService: Send OTP
    User->>EmailOTP: Verify OTP
    EmailOTP->>EmailVerif: Email verification complete
    note over EmailVerif: Default verification (welcome email NOT sent)
    end

    rect rgba(0, 255, 0, 0.1)
    note over User,EmailService: After Fix: overrideDefaultEmailVerification = true
    User->>EmailOTP: Sign up via Email/OTP
    EmailOTP->>EmailService: Send OTP
    User->>EmailOTP: Verify OTP
    EmailOTP->>EmailVerif: Email verification complete
    EmailVerif->>WelcomeEmail: afterEmailVerification hook triggered
    WelcomeEmail->>EmailService: Send welcome email
    EmailService-->>User: Welcome email delivered
    end

Loading