fix(terminal): pop all entries from a single execution when the limit is exceeded#2815
Merged
waleedlatif1 merged 1 commit intostagingfrom Jan 14, 2026
Merged
fix(terminal): pop all entries from a single execution when the limit is exceeded#2815waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryChanged the terminal console store's trimming logic to maintain execution atomicity when the entry limit is exceeded. Previously, the store would trim entries per workflow by simply counting up to Key changes:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant addConsole
participant State
participant Trimming Logic
participant Storage
User->>addConsole: Add new console entry
addConsole->>addConsole: Redact API keys
addConsole->>addConsole: Create entry with UUID & timestamp
addConsole->>State: Prepend to entries array
State->>Trimming Logic: Check if trimming needed
Trimming Logic->>Trimming Logic: Group entries by workflowId
loop For each workflow group
Trimming Logic->>Trimming Logic: Count entries per workflow
alt Entries > MAX_ENTRIES_PER_WORKFLOW
Trimming Logic->>Trimming Logic: Build execution order list
Trimming Logic->>Trimming Logic: Count entries per execution
Trimming Logic->>Trimming Logic: Keep newest executions (atomic)
Trimming Logic->>Trimming Logic: Mark old executions for removal
end
end
Trimming Logic->>State: Filter out marked executions
State->>Storage: Persist trimmed entries
addConsole->>User: Return new entry
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist