fix(ff): add back condition for isHosted FF#2789
Merged
waleedlatif1 merged 2 commits intostagingfrom Jan 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a critical regression that broke self-hosted deployments by restoring the conditional Key Changes:
Impact: Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant App as Application
participant FF as feature-flags.ts
participant Env as env.ts
participant Config as Environment Config
Note over App,Config: Feature Flag Check Flow
App->>FF: Check isHosted flag
FF->>Env: getEnv('NEXT_PUBLIC_APP_URL')
Env->>Config: Retrieve NEXT_PUBLIC_APP_URL
Config-->>Env: Return URL value
Env-->>FF: Return URL string
alt URL is https://www.sim.ai
FF-->>App: isHosted = true
else URL is https://www.staging.sim.ai
FF-->>App: isHosted = true
else URL is other (self-hosted)
FF-->>App: isHosted = false
end
Note over App,FF: URL Construction Flow
App->>FF: Need base URL for deployment
FF->>Env: getBaseUrl()
Env->>Config: Retrieve NEXT_PUBLIC_APP_URL
Config-->>Env: Return URL
Env-->>FF: Validated base URL
FF-->>App: Construct endpoint URLs
Note over App: Deploy modal, chat, and form<br/>now use consistent getBaseUrl()<br/>instead of direct getEnv() calls
|
waleedlatif1
added a commit
that referenced
this pull request
Jan 13, 2026
* fix(ff): add back condition for isHosted FF * updated callers to use getBaseUrl()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist